Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch the web app automatically #115

Closed
xmha97 opened this issue Dec 29, 2021 · 9 comments
Closed

Launch the web app automatically #115

xmha97 opened this issue Dec 29, 2021 · 9 comments
Labels
enhancement New feature or request
Milestone

Comments

@xmha97
Copy link
Contributor

xmha97 commented Dec 29, 2021

Hi, I want to see YouTube videos on the web app instead of the browser (Firefox).
Please add an option to launch the web app automatically.
image
Thanks.

@xmha97 xmha97 added the enhancement New feature or request label Dec 29, 2021
@xmha97 xmha97 changed the title Launch to web app automatically Launch the web app automatically Dec 29, 2021
@filips123 filips123 added this to the 1.5.0 milestone Dec 29, 2021
@markcellus
Copy link

This request confuses me. I thought web apps can only be viewed in a browser. 🤔

@xmha97
Copy link
Contributor Author

xmha97 commented Dec 30, 2021

This request confuses me. I thought web apps can only be viewed in a browser. 🤔

In Android, web apps can be installed like a native app. (See WebAPK)

image

I need this feature for Windows.

@markcellus
Copy link

markcellus commented Dec 30, 2021

Right but, in your Android example, that web app is still inside of the browser you used to "install" it. It just doesn't look like it's in a browser, because it doesnt display the browser chrome (e.g. toolbar, header, footer etc), but it is definitely in the browser.

@filips123
Copy link
Owner

I think he means to launch PWA automatically (so, probably close the current browser tab and launch PWA on the same URL) when you open a website that has been installed as PWA. This is similar as an option in mobile browsers to open website in a native app if it exists. I'll probably add some option to enable this in the future (but disabled by default).

But there are few things to consider:

  • Just closing current tab might be annoying, as it would also close a previous website (in case link had a default target of opening in the same tab). Forcing all such URLs into a new tab would probably mostly solve this issue, but I'm not sure if this is possible with extensions.

  • It may cause some issues in the same way as "Open out of scope URLs in a default browser" does, for example, with SSO. To solve this, we could have an option to disable this behavior for specific PWAs or domains.

  • What if there are multiple PWAs installed for the same website. On Chrome, Edge and Android, this is not possible, so they can just open installed PWA, but I intentionally added support to install multiple websites as different PWAs in different profiles. How should opening behave in this case? Should it just do nothing, or should it display some popup to let user choose which PWA to open?

@xmha97
Copy link
Contributor Author

xmha97 commented Dec 30, 2021

Thank you for your explanation.

  • What if there are multiple PWAs installed for the same website. On Chrome, Edge and Android, this is not possible, so they can just open installed PWA, but I intentionally added support to install multiple websites as different PWAs in different profiles. How should opening behave in this case? Should it just do nothing, or should it display some popup to let user choose which PWA to open?

I don't install multiple PWAs for the same website but I think it should display some popup to let the user choose which PWA to open. Is it hard to implement?

@filips123
Copy link
Owner

I think it shouldn't be too hard.

@xmha97
Copy link
Contributor Author

xmha97 commented Jun 12, 2022

I think it shouldn't be too hard.

@filips123 Do you have a plan to implement this feature?

@filips123
Copy link
Owner

Yes, but I was doing some other things and I didn't have time yet.

@filips123
Copy link
Owner

This will be available in 2.0.0. To use it, you first need to enable it from the extension settings ("Enable automatic web app launching") and separetly for each web app ("Auto launch this web app"):

settings

However, please note that the feature is experimental and may not work with all websites. It will probably also impact the performance of loading all websites while enabled because it will need to run firefoxpwa-connector for every request in order to determine whether launching is enabled. I will try to improve this in the future, but I'm not sure yet how.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants