Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper scripts for building from source #193

Closed
JJRcop opened this issue Aug 3, 2022 · 1 comment · Fixed by #372 or #371
Closed

Add helper scripts for building from source #193

JJRcop opened this issue Aug 3, 2022 · 1 comment · Fixed by #372 or #371
Labels
enhancement New feature or request
Milestone

Comments

@JJRcop
Copy link
Contributor

JJRcop commented Aug 3, 2022

Problem Description

Building from source requires hand-editing some files, which is slightly tedious, but only trivially so.

Proposed Solution

Add some helper scripts under native/ and extension/ in both windows batch and POSIX sh formats, (or node.js, cross platform) They could simply take an argument which is the version to replace, maybe perform validation that it confirms to the proper version format, and edit the files themselves.

If you want to be fancy, they could look at the current git tag from git describe and use that (maybe filtering out the leading "v")

Additional Information

I am able to make these myself, but I have a weird head on my shoulders and will probably delay for a while until eventually getting around to it, sorry.

@JJRcop JJRcop added the enhancement New feature or request label Aug 3, 2022
@filips123
Copy link
Owner

I agree that would be useful. Parsing the Git tag would also be very nice. Something similar is already done inside GitHub Actions for publishing, so I can probably just copy and slightly adjust that to some reusable scripts.

For native/, it could be inside the existing Makefile.toml, as cargo-make can automatically transpile (basic) bash commands to Windows batch, or use cross-platform duckscript in case transpiling doesn't work. This would also be useful because then you could just run something like makers prepare and then already existing makers install to install the package (but they should be separate commands)

For extension/, Node.js script could be used.

@filips123 filips123 added this to the 2.1.0 milestone Aug 5, 2022
@filips123 filips123 removed this from the 2.1.0 milestone Sep 18, 2022
@filips123 filips123 added this to the 2.7.3 milestone Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
2 participants