Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The checkboxes in in the edit menus for PWAs in the Extension, could be explained more clearly #195

Closed
DanielSvindseth opened this issue Aug 5, 2022 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@DanielSvindseth
Copy link

Description

Like the title says, I am unable to disable automatic icon updates.

Steps to Reproduce

  1. Click 'edit' on a PWA in the extension's menu
  2. Scroll down and uncheck the box that says "Update web app icons"
  3. Click 'edit' to apply changes
  4. Go back to the main extension menu
  5. Repeat step 1, and the checkbox should be toggled on again :/

Additional Information

Affected Websites

All from what I can see

  • ...
  • ...

Environment

  • Operating system: Fedora 36
  • System architecture: x86_64
  • Desktop environment: Gnome 42
  • Installation method: RPM
  • PWAsForFirefox extension version: 2.0.1
  • PWAsForFirefox native version: 2.0.1-1
  • Firefox version: 102.0
@DanielSvindseth DanielSvindseth added the bug Something isn't working label Aug 5, 2022
@filips123
Copy link
Owner

This is expected. "Update web app icons" and "Update web app manifest" only determine if icons and manifest will be updated when you click the "Edit" button. They are not stored anywhere after the process has been finished, and icons and manifest are not automatically updated in any case.

I could probably add some tooltips to those checkboxes to make that more clear...

@DanielSvindseth
Copy link
Author

Ah! That makes some sense.

Yeah maybe a tooltip or something similar could help people like me who doesn't understand that from the beginning.

@DanielSvindseth DanielSvindseth changed the title Disabling "Update web app icons" from the Extension menu does not work The checkboxes in in the edit menus for PWAs in the Extension, could be explained more clearly Aug 7, 2022
@filips123 filips123 added this to the 2.0.2 milestone Aug 7, 2022
@filips123 filips123 added enhancement New feature or request and removed bug Something isn't working labels Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants