-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forced open link confirmation popup #435
Comments
Yeah same here. I was wondering if this is a recent OS level dialog and not specific to this codebase. But you're using Fedora and I'm using Ubuntu and getting same error, so doesn't appear to be an OS-specific issue. |
This is a change in Firefox 121, which was made to fix security vulnerability CVE-2023-6871. This was done in this patch, but the full bug report is still private, so I don't know what exactly the issue was. I don't know yet if this popup can be disabled specifically for default browser popups. I'll check how exactly the popup works and if it's possible to hide it when opening the default browser. Maybe unsafe workaround: You can also disable the popup for all external protocols by setting the I don't know what the latest vulnerability is about, but for example, another issue that was related to this preference a few years ago, was that opening a Zoom meeting link would automatically launch the Zoom client and join you into the meeting. Disabling this preference might again cause this behavior and other similar issues. So, I would recommend you not to do this, but if you're aware of the risks, you can disable that preference. I hope I will be able to disable that popup specifically for opening a default browser in the future. |
Can confirm. I've also noticed some apps do not even open after confirming the link. Specifically a discord PWA I installed. Perhaps that is a different bug though. |
@MisakaImoutoWaifu Do you mean that the links that you click do not open in a default browser, or that the whole PWA does not even start? Also, does this problem also happen when "open out-of-scope URLs in a default browser" is disabled? |
It turned out at some point the default handler changed. It was set as Firefox, but a stale reference to it. Not sure what caused it, but I think it was unrelated to this issue. |
How did you find this? I think I am having the same issue |
Apologies everyone for the spam, just feel like I need to add a comment with the exact text of the error:
Hopefully this might help it appear in search results, took me a while to find this bug report. |
Go to about:preferences and then scroll down to the "Applications" section. Change the "http" and "https" entries to your firefox binary. |
This has been fixed in 2.10.0. The confirmation popup will no longer be shown for HTTP(S) links. Once you update to the new version, you should probably re-enable |
Description
Before a recent update, clicking a link in a PWA would open the link in my default browser (Firefox) as configured in my settings:
Now whenever I click a link I get this dialog:
And am then forced to wait 3 seconds for the open button to become enabled.
This means for every link I need to click the link, wait 3 seconds, and then click a dialog box. I understand the intention, but this option should be something the user can disable, as it breaks workflows.
Steps to Reproduce
Affected Websites
All websites
Environment
The text was updated successfully, but these errors were encountered: