-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ctrl+W closes the PWA #443
Comments
I see there is a ac5032f but maybe make the default behavior in-sync with the Chromium one, to not confuse the users? |
But if |
Well, as it's an "application" now it's more expected it would want to handle such combination itself. My 2 cents. |
Yeah, but I still think it's better to have the same shortcuts as normal Firefox. In any case, disabling the shortcut takes just a few clicks if you need it disabled. So, I'll close this issue. Another possibility is to keep the shortcut normally enabled, but allow the website to overwrite it. I think this is what Edge (and probably Chromium) does. I may add another option for this (which may be enabled by default) in the future, but I cannot guarantee when, as first I want to clean up and improve some existing code. |
Let's make task/issue for that to track? |
Ok, I will create it soon. |
I created #446. Also, please comment there if you know any other shortcuts that are commonly used in PWAs and conflict with built-in Firefox options (apart from ones already on the list). |
Description
The Ctrl+W shortcut is intercepted by browser and closes the PWA (as it's default shortcut to close a tab), even if it's used by the PWA itself.
Steps to Reproduce
Additional Information
There is no such problem with Chromium PWAs - tabs in Chromium are also closed by Ctrl+W, but PWAs there handle the shortcut correctly and do not close the window.
Affected Websites
Environment
The text was updated successfully, but these errors were encountered: