Ctrl+W closes the PWA

[bam80]

Description

The Ctrl+W shortcut is intercepted by browser and closes the PWA (as it's default shortcut to close a tab), even if it's used by the PWA itself.

Steps to Reproduce

1. Open any installed PWA. Good example - Github's Codespaces.
2. Press Ctrl+W
3. The PWA window closes immediately

Additional Information

There is no such problem with Chromium PWAs - tabs in Chromium are also closed by Ctrl+W, but PWAs there handle the shortcut correctly and do not close the window.

Affected Websites

Environment

• Operating system: Ubuntu 23.04
• Desktop environment: Gnome
• Installation method: DEB
• Extension version: 2.9.1
• Native version: 2.9.1
• Runtime version: 121.0.1
• Firefox version: 121.0

[bam80]

I see there is a ac5032f but maybe make the default behavior in-sync with the Chromium one, to not confuse the users?

[filips123]

But if Ctrl+W is disabled by default, that may confuse Firefox users who expect it to close the tab (and the window if it's the only tab)...

[bam80]

Well, as it's an "application" now it's more expected it would want to handle such combination itself.
Also, I think it's still better to keep this behavior consistent between different PWA vendors, as casual user shouldn't care much which vendor provides the PWA but just expects consistent behavior of the app itself.

My 2 cents.

[filips123]

Yeah, but I still think it's better to have the same shortcuts as normal Firefox. In any case, disabling the shortcut takes just a few clicks if you need it disabled. So, I'll close this issue.

Another possibility is to keep the shortcut normally enabled, but allow the website to overwrite it. I think this is what Edge (and probably Chromium) does. I may add another option for this (which may be enabled by default) in the future, but I cannot guarantee when, as first I want to clean up and improve some existing code.

[bam80]

I may add another option for this

Let's make task/issue for that to track?

[filips123]

Ok, I will create it soon.

[filips123]

I created #446. Also, please comment there if you know any other shortcuts that are commonly used in PWAs and conflict with built-in Firefox options (apart from ones already on the list).