Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Instead of scraping, just load a yaml file from GitHub Directly #1

Closed
filiptronicek opened this issue Jul 10, 2020 · 3 comments · Fixed by #2
Closed

Instead of scraping, just load a yaml file from GitHub Directly #1

filiptronicek opened this issue Jul 10, 2020 · 3 comments · Fixed by #2
Assignees
@filiptronicek
Labels
enhancement New feature or request

Comments

@filiptronicek
Copy link
Owner

Pros of this:

  • faster response times
  • will probably break less

Cons:

  • literally none
@filiptronicek filiptronicek added the enhancement New feature or request label Jul 10, 2020
@filiptronicek filiptronicek self-assigned this Jul 10, 2020
@filiptronicek
Copy link
Owner Author

The Czech Republic YAML sits here: https://github.com/lauripiispanen/github-top/blob/master/_data/locations/czech_republic.yml

@filiptronicek
Copy link
Owner Author

Now I have to find a YAML parser for Python, bruh

@filiptronicek
Copy link
Owner Author

OK, pyyaml will do the job.

Stuff for future me to read about:
https://stackabuse.com/reading-and-writing-yaml-to-a-file-in-python/
https://pypi.org/project/PyYAML/

@filiptronicek filiptronicek mentioned this issue Jul 12, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@filiptronicek filiptronicek

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Load from GitHub yaml filiptronicek/commits-top-api
1 participant
@filiptronicek