Test issues when running from a folder containing a space character in its name #629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the DotNet.Script solution resides in a folder containing a space character in its name, an avalanche of test failures occurs due to the absence of escaping of command line arguments.
The enclosed pull request fixes all those issues.
Besides tests, there was a similar issue in
DotNetRestorer
class that was fixed as well by employing a batte-tested string escaping algorithm from Gapotchenko.FX.Diagnostics.CommandLine package.An intricate detail of NuGet's
-s
argument is that it may end with\
character (e.g. the last separator in a folder path), so such a naive escaping approach as$"-s \"{s}\""
would not work here, as it will cause an unanticipated escape of the escape character"
. Hence the usage of a proper escape function here to isolate the customer-supplied data.