Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak in AppDomain.AssemblyResolve event subscription #630

Merged
merged 2 commits into from
Aug 18, 2021
Merged

Memory leak in AppDomain.AssemblyResolve event subscription #630

merged 2 commits into from
Aug 18, 2021

Conversation

hrumhurum
Copy link
Contributor

There is a memory leak in AppDomain.AssemblyResolve event subscription that manifests itself on subsequent script executions.

A similar issue is reported in #598.

The proposed changes reliably fix the issue.

Copy link
Collaborator

@seesharper seesharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM 👍. This is something I totally forgot about. Thanks 😊

Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants