Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for .NET Core 2.1 #633

Merged
merged 3 commits into from
Aug 23, 2021
Merged

drop support for .NET Core 2.1 #633

merged 3 commits into from
Aug 23, 2021

Conversation

filipw
Copy link
Member

@filipw filipw commented Aug 23, 2021

.NET Core 2.1 reached end of life 2 days ago https://dotnet.microsoft.com/platform/support/policy/dotnet-core

@filipw filipw requested a review from seesharper August 23, 2021 14:34
Copy link
Collaborator

@seesharper seesharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One less thing to worry about. I had just one comment on the shebang

README.md Outdated
@@ -316,7 +313,7 @@ To consume a script package all we need to do specify the NuGet package in the `
The following example loads the [simple-targets](https://www.nuget.org/packages/simple-targets-csx) package that contains script files to be included in our script.

```C#
#! "netcoreapp2.1"
#! "netcoreapp3.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used anymore so it should probably be removed from the docs

a10f53a

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks I forgot about that

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants