Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembly isolation opt-in at dotnet-script level #637

Merged
merged 4 commits into from
Aug 26, 2021
Merged

Assembly isolation opt-in at dotnet-script level #637

merged 4 commits into from
Aug 26, 2021

Conversation

hrumhurum
Copy link
Contributor

Due to difficulties and relative immaturity of AssemblyLoadContext support, assembly isolation should be opt-in at dotnet-script level for now.

This PR implements this by introducing --isolated-load-context command-line option in dotnet-script.

@seesharper
Copy link
Collaborator

@hrumhurum The build failed because of some network issue. I can't find where to restart the build. Can you just push an empty commit to restart?

git commit --allow-empty -m "Trigger Build"

Copy link
Collaborator

@seesharper seesharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 👍

@seesharper seesharper requested a review from filipw August 26, 2021 19:43
Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@filipw filipw merged commit 4240e54 into dotnet-script:master Aug 26, 2021
@seesharper
Copy link
Collaborator

@hrumhurum Just wanted to say thanks for reacting so quickly to the problem. 👍😊

@SamVanheer SamVanheer mentioned this pull request Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants