Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change tests to typescript #7

Closed
dcallus opened this issue May 25, 2022 · 2 comments
Closed

Change tests to typescript #7

dcallus opened this issue May 25, 2022 · 2 comments

Comments

@dcallus
Copy link
Contributor

dcallus commented May 25, 2022 •
edited

The current tests in the test folder are in JavaScript as mocha is a js framework. Find an alternative as it sucks to lose type safety. Perhaps use chai with mocha?
@dcallus
Copy link
Contributor Author

dcallus commented May 26, 2022

ts-jest is the solution. It won't require basically any changes to the tests.

Have an experimental branch feature/typescript-test but it's not working yet, it seems to be conflicting with the tests that are added automatically by create-react-app boilerplate.

@dcallus
Copy link
Contributor Author

dcallus commented May 27, 2022

Done.. However the react-pro-metronome tests have been temporarily removed. These will need to be reinstated before any changes (e.g. updated to typescript) to react-pro-metronome fork are done.

@dcallus dcallus closed this as completed May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dcallus