WaveWriter - WaveHeader is not fully valid.

[ThuCommix]

https://github.com/filoe/cscore/blob/master/CSCore/Codecs/WAV/WaveWriter.cs#L249

If I read the WaveHeader the DataSize is always zero.

            waveHeader.RiffId = br.ReadBytes(4);
            waveHeader.Size = br.ReadUInt32();
            waveHeader.WavId = br.ReadBytes(4);
            waveHeader.FmtId = br.ReadBytes(4);
            waveHeader.FmtSize = br.ReadUInt32();
            waveHeader.Format = br.ReadUInt16();
            waveHeader.Channels = br.ReadUInt16();
            waveHeader.SampleRate = br.ReadUInt32();
            waveHeader.BytesPerSec = br.ReadUInt32();
            waveHeader.BlockSize = br.ReadUInt16();
            waveHeader.Bit = br.ReadUInt16();
            waveHeader.DataId = br.ReadBytes(4);
            waveHeader.DataSize = br.ReadUInt32();

So I guess _dataLength is 0 at the time of writing the header? Most playback devices ignore the wrong data length flag, but some (mine) need this flag for validity checks.

[ThuCommix]

Also confirmed for 1_1.

[filoe]

Did you dispose the WaveWriter?

[ThuCommix]

Yes, I'm using it in a using-block. Sorry for late reply.

[filoe]

I am going to have a look at it. But you could take a look at the cscore decoder. The cscore decoder should be able to read the datasize.

[ThuCommix]

Do you mean the WaveFileReader? If yes it simply ignores the data length.

[filoe]

Ok, I am going to debug it today or in the next few days. But by just reading the code, I can't find any mistake in the WaveWriter class. Every Write operation increments the _dataLength correctly. And the Dispose method calls the WriteHeader method which writes down the _dataLength at the correct position.

[ThuCommix]

You also writing the header in the ctor https://github.com/filoe/cscore/blob/master/CSCore/Codecs/WAV/WaveWriter.cs#L54

[filoe]

Of course, the line you mentioned reserves some space for the header inside of the stream. But the content of the header gets written by the WriteHeader method which gets called in the Dispose method: https://github.com/filoe/cscore/blob/master/CSCore/Codecs/WAV/WaveWriter.cs#L265

[ThuCommix]

Yes but line 60 is still not necessary as far as I can see. But thats not the problem just a side note 🍡

[filoe]

You're right, line 60 or the loop at line 54 would not be necessary.

[ThuCommix]

Also you could seek the stream by 44 bytes so you don't need to write 0 44 times. Don't know if this would bring a bit more performance.

[filoe]

You're right again, but I can't reproduce your issue. I am sorry. I've just encoded a wav file:

And the cscore also is able to read it correctly:

But let me tell you, that your decoder won't work for all wav files. In order to be more flexible what different wav files concerns, you may should implement wave file chunks instead of reading the fmt and data chunk straigt forward.

[filoe]

Still waiting on any updates...

[filoe]

Since this issue could not be reproduced, and @ThuCommix did not respond for months... I would guess I can close this.