Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with Pimple #244

Closed
mathroc opened this issue Nov 7, 2014 · 4 comments
Closed

Integration with Pimple #244

mathroc opened this issue Nov 7, 2014 · 4 comments

Comments

@mathroc
Copy link

mathroc commented Nov 7, 2014

Hi,

I just made a framework integration package for Pimple : https://packagist.org/packages/texthtml/whoops-pimple

This one does not rely on Silex, but needs Pimple ~3.0. It might solves #228

@denis-sokolov
Copy link
Collaborator

Thanks!

@mathieuprog
Copy link

I think that $container['whoops']->register(); doesn't belong in the provider's register() method.
What it does is retrieve the Whoops\Run object and execute it. However register() should only register dependencies and not retrieve and execute these. Registering the dependency doesn't necessarily mean that I will use it.

@denis-sokolov
Copy link
Collaborator

This seems a very useful feedback.
Would you mind submitting it on the page for the whoops-pimple project?
This issue was only about creating a text link to that project.

@mathieuprog
Copy link

The thing is that the other service providers do the same thing (phalcon, silex), not only pimple's.
Anyway, I created my own service provider for my framework because it seems that the way I manage my dependencies is done a little bit differently.
Thank you for your support in any case:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants