Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation on SBT dependencies #1194

Open
ComFreek opened this issue Dec 19, 2019 · 3 comments
Open

Improve documentation on SBT dependencies #1194

ComFreek opened this issue Dec 19, 2019 · 3 comments
Labels

Comments

@ComFreek
Copy link
Contributor

ComFreek commented Dec 19, 2019

I had to spend >= 30min to figure out that I needed the following dependencies to run what the docs currently claim to only need finch-circe and 2 imports:

libraryDependencies ++= Seq(
  "com.github.finagle" %% "finchx-core" % "0.31.0",
  "com.github.finagle" %% "finchx-circe" % "0.31.0",
  "io.circe" %% "circe-generic" % "0.12.3"
)

I found the above dependencies in the finch/finch.g8 repo, however a) I had to look in a build.sbt in some sub^n-directory and b) it did not contain versions, so I had to look them up manually on Maven central.

Apparently, #1022 had a very similar issue. There it reads that "Finch is very unfriendly with first time users". Unfortunately, it seems it still is to some extent. Let's improve that 😄

@baughmann
Copy link

baughmann commented Apr 25, 2020

Well, it's been just over three months and this is still the case. Not only that, but the dependencies that @ComFreek do not work anymore.

EDIT:
To get the latest version of Finch, try the following:

val finchVersion = "0.32.1"

libraryDependencies ++= Seq(
  "com.github.finagle" %% "finchx-core"  % finchVersion,
  "com.github.finagle" %% "finchx-circe"  % finchVersion,
)

@well1791
Copy link

well1791 commented Oct 27, 2021

@baughmann thank you! <3

EDIT:

@baughmann mind to share how to install the lib on a scala3 project (if possible)? 🤔

@baughmann
Copy link

baughmann commented Oct 27, 2021

@well1791 Sorry man, I really haven't been using Scala at all since my last comment

@joroKr21 joroKr21 added the docs label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants