Form can be submitted when async validations are running

[Zn4rK]

What is the current behavior?

If there's any async validation happening, onSubmit will be called regardless of their status.

What is the expected behavior?

onSubmit shouldn't be called until all validators have resolved. FormState.valid is true even though it might not be true.

Sandbox Link

https://codesandbox.io/s/lv3y8mzjm

What's your environment?

final-form@4.2.0

Other information

Failing test

it('should not submit if form is still validating', () => {
  const onSubmit = jest.fn()
  const form = createForm({ onSubmit });

  const username = jest.fn()
  form.registerField('username', username, { error: true }, {
    getValidator: () => () => {
      return new Promise(resolve => resolve('Error'))
    }
  })

  form.submit()
  expect(onSubmit).not.toHaveBeenCalled()
})

[erikras]

A bug report with a failing test!! 😍

[erikras]

Published fix in v4.2.1.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.