Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revers decorators unsubscriptions #618

Closed
adascal opened this issue Sep 9, 2019 · 1 comment · Fixed by #620
Closed

Revers decorators unsubscriptions #618

adascal opened this issue Sep 9, 2019 · 1 comment · Fixed by #620

Comments

@adascal
Copy link
Contributor

adascal commented Sep 9, 2019 •
edited

react-final-form/src/ReactFinalForm.js

Line 111 in 3add0f3

unsubscriptions.forEach(unsubscribe => unsubscribe())

Shouldn't unsubscriptions be reversed before doing unsubscribe?
Then we have multiple decorators rewriting form.submit seems like it's restored in a wrong way

For example, I'm using final-form-focus and my own
@adascal adascal mentioned this issue Sep 10, 2019
Merged
@erikras
Copy link
Member

erikras commented Nov 18, 2019

Published fix in v6.3.1.

@snyk-bot snyk-bot mentioned this issue Nov 28, 2019
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: decorators unsubscribe order adascal/react-final-form
2 participants
@erikras @adascal