Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sfiii3u Graphics Misalignment [Regression] #278

Closed
Awakened0 opened this issue Feb 15, 2020 · 6 comments
Closed

sfiii3u Graphics Misalignment [Regression] #278

Awakened0 opened this issue Feb 15, 2020 · 6 comments

Comments

@Awakened0
Copy link

There's a strange alignment problem I found that's best shown with a comparison: http://www.framecompare.com/image-compare/screenshotcomparison/J2ME1NNU

You can also see a slight difference in colors compared to MAME. I've only tested the libretro core; not sure if these are there in stand alone.

@Awakened0
Copy link
Author

Ahh, it's aligned properly in a build from Jan 31st, so it must be something with the recent CPS3 changes.

@Awakened0 Awakened0 changed the title sfiii3u Graphics Misalignment sfiii3u Graphics Misalignment [Regression] Feb 15, 2020
@dinkc64
Copy link
Collaborator

dinkc64 commented Feb 15, 2020

@barbudreadmon maybe its something to do with that offset we were talking about the other night?

@barbudreadmon
Copy link
Collaborator

I'll be away this week-end, i'll try to see what's wrong next week. Leaving in a few minutes, 1 wild guess would be 900ce38#diff-d51bfb6a692321f4224209e955b76d48R1829 and next line
I did the "+1" change to follow current mame code but this change wasn't part of the commit i backported

@dinkc64
Copy link
Collaborator

dinkc64 commented Feb 15, 2020

barbudreadmon, that was it :) I committed the change

@Awakened0
Copy link
Author

Built the libretro core with that change and it looks good. Thanks!

@barbudreadmon
Copy link
Collaborator

cool :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants