Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS2019 broken #49

Closed
LodanZark opened this issue Jun 8, 2019 · 5 comments
Closed

VS2019 broken #49

LodanZark opened this issue Jun 8, 2019 · 5 comments

Comments

@LodanZark
Copy link

LodanZark commented Jun 8, 2019

After the latest commits related with new drivers of berzerk and frenzy, I am unable to compile it through VS2019.
The log it's attached to this ticket: log.txt

@dinkc64
Copy link
Collaborator

dinkc64 commented Jun 8, 2019

Just fy: After a new driver is added, the vs builds will need to be updated. Sorry about that, but I don't use VS.
@tmaul, can you please help with this? :)

@barbudreadmon
Copy link
Collaborator

It seems related to not having the new d_berzerk.cpp in the .vcxproj file.
Is there no way to manage the standalone (both gcc & vs) filelist the same way as we do in the libretro port ?
What we do there is this :
https://github.com/libretro/FBNeo/blob/e873ce92c835713b865dfa550e38ff96f84bd6cf/src/burner/libretro/Makefile.common#L315-L316
where FBNEO_SRC_DIRS is the list of folders with files to build, and BURN_BLACKLIST is a list of files to not build. I think this method requires less maintenance.

@tmaul
Copy link
Member

tmaul commented Jun 8, 2019

We can use cmake to build for different toolchains. I will update the vs2019 solution this evening but cmake will take a bit longer. Worth doing though when one of us has time

@tmaul
Copy link
Member

tmaul commented Jun 8, 2019

@LodanZark This should be fixed now, please let me know if you still have problems :)

@LodanZark
Copy link
Author

@tmaul yes it's fixed now ;) tyvm

KScl pushed a commit to KScl/FBNeo that referenced this issue Jan 6, 2023
d_neogeo: ms hacks - name changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants