test 1.5.1 fails if entry is in multiple files

[jamesleetong]

test 1.5.1 fails if the configuration is listed on multiple files

grep "fs.suid_dumpable" /etc/sysctl.conf /etc/sysctl.d/*.conf

/etc/sysctl.conf:fs.suid_dumpable = 0
/etc/sysctl.d/99-sysctl.conf:fs.suid_dumpable = 0

the next comparison will fail, as there are multiple lines output being compared.
sed 's/^.*://')" == "fs.suid_dumpable = 0"

maybe add a pipe to uniq to resolve this?

[ "$(grep "fs.suid_dumpable" /etc/sysctl.conf /etc/sysctl.d/.conf | sed 's/^.://' | uniq)" == "fs.suid_dumpable = 0" ]

[Joseph94m]

I'm also having this issue. The 99-sysctl.conf file has a reference to the /etc/sysctl.conf file.
This also happens with the 1.5.3 test.

[Joseph94m]

[ "$(grep "fs.suid_dumpable" /etc/sysctl.conf /etc/sysctl.d/.conf | sed 's/^.://' | uniq)" == "fs.suid_dumpable = 0" ]

There should be a star before ".conf" in that command

[finalduty]

Hey @jamesleetong and @Joseph94m, thanks for your reports and my apologies for not getting on to this sooner.

I have replicated this issue and @jamesleetong I think piping through uniq is a good solution for 1.5.1 and 1.5.3. I have updated the script with your suggestion and will push it shortly. I have also applied this to the functions responsible for tests 3.1.1 through 3.3.2 which use similar logic.