Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NdNorms ChunkIdentifier not in header. #101

Closed
sebpuetz opened this issue Oct 20, 2019 · 1 comment
Closed

NdNorms ChunkIdentifier not in header. #101

sebpuetz opened this issue Oct 20, 2019 · 1 comment
Assignees
@danieldk @sebpuetz
Labels
bug Something isn't working
Milestone
release-0.11

Comments

@sebpuetz
Copy link
Member

I'm implementing stand-alone reading + writing for the different chunks in my Python fork and it seems like we never added the `NdNorms' chunk identifier to the list in the header.

I think it's not a breaking change if we add the identifier to the header. Inside finalfusion, we don't use the chunk identifiers for storage, vocab and norms in any way, iirc.
@sebpuetz sebpuetz added the bug Something isn't working label Oct 20, 2019
@sebpuetz sebpuetz added this to the release-0.11 milestone Oct 20, 2019
@danieldk
Copy link
Member

Fixed by #102 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danieldk danieldk

@sebpuetz sebpuetz

Labels
bug Something isn't working
Milestone
release-0.11
Development

No branches or pull requests
2 participants
@danieldk @sebpuetz