Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of FP related to Trust Boundary Violation #226

Closed
h3xstream opened this issue Oct 3, 2016 · 1 comment
Closed

Reduce the number of FP related to Trust Boundary Violation #226

h3xstream opened this issue Oct 3, 2016 · 1 comment
Assignees
Labels
enhancement New feature or improvement to existing detector.
Milestone

Comments

@h3xstream
Copy link
Member

h3xstream commented Oct 3, 2016

Trust Boundary Violation is one of the most noisy rule. The main reason that stop me from eliminating most of the occurrence is that OWASP Benchmark look mostly for low risk TBV.

Two distinct TBV can be identify :

1. Attribute name altered : This seems to be the most dangerous case. It has some potential messing with the application internal state.

req.getSession().setAttribute(input,"true");

2. Attribute value alter : This is the most common and less likely to introduce a vulnerability by itself.

req.getSession().setAttribute("user", user);

Instead of removing the second type, I would vote for setting it priority (confidence) to LOW at worst.
This way this "FP producer" will not pollute day to day review by developers.

@h3xstream h3xstream added the enhancement New feature or improvement to existing detector. label Oct 3, 2016
@h3xstream h3xstream added this to the version-1.5.0 milestone Oct 3, 2016
@h3xstream h3xstream self-assigned this Oct 3, 2016
@h3xstream
Copy link
Member Author

Changeset:

ae46a6f
09485eb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement to existing detector.
Projects
None yet
Development

No branches or pull requests

1 participant