Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IP to notification while monitoring #60

Closed
uBadRequest opened this issue Feb 4, 2020 · 5 comments
Closed

Add IP to notification while monitoring #60

uBadRequest opened this issue Feb 4, 2020 · 5 comments
Assignees
Labels
fixed Issue solved of feature request implemented. implemented-in-plus-version Request for enhancement implemented in Findomain+. request-for-enhancement New feature or request

Comments

@uBadRequest
Copy link

Could we get an option to add what a discovered subdomain is resolving to in the notification that is send to discord?

@Edu4rdSHL Edu4rdSHL changed the title [Enhancement] Add CNAME or IP to notification Add CNAME or IP to notification while monitoring Feb 4, 2020
@Edu4rdSHL
Copy link
Member

Edu4rdSHL commented Feb 4, 2020

Hello, I will send the resolved domains in the format domain.tld,IP address. Have in mind that enabling it option you will only got there non NX domains (only exisintg ones), that's how the current resolver works: if IP == NULL, don't return anything. It's ok?

Though we need more feedback from the community before working on it.

@Edu4rdSHL Edu4rdSHL added discussing Needs discussion to decide what to do request-for-enhancement New feature or request labels Feb 4, 2020
@uBadRequest
Copy link
Author

Yes thats fine. It will help me easily distinguish between domains that have been registered but aren't pointing anywhere.

How FindDomain is currently designed, how easy would it be to send a notification if a found subdomain starts pointing to a CNAME or IP address?

@Edu4rdSHL
Copy link
Member

How FindDomain is currently designed, how easy would it be to send a notification if a found subdomain starts pointing to a CNAME or IP address?

Findomain is designed in a very modular way, every step is done by a independent and optimized function for that step specifically but at same time every function can work together with another function without any problem. The asynchronous resolver is:

https://github.com/Edu4rdSHL/findomain/blob/3e5fd138584341ee1563db78bb0ee9a10be7867a/src/lib.rs#L255-L276

Currently the resolver is only capable of discover IP, not CNAME, it isn't hard to implement but I need to add a new feature, then I can work with CNAME. Talking about the possibility to send the domain.tld,ip format to webhooks, isn't hard, I need to add a couple of lines to do that but sincerely is more a logic implementation.

So, I'm going to delete "CNAME" for the issue title and if you want to work with CNAME record, open another request for enhancement.

@Edu4rdSHL Edu4rdSHL changed the title Add CNAME or IP to notification while monitoring Add IP to notification while monitoring Feb 5, 2020
@Edu4rdSHL Edu4rdSHL removed the discussing Needs discussion to decide what to do label Feb 9, 2020
@Edu4rdSHL Edu4rdSHL self-assigned this Feb 9, 2020
@uBadRequest
Copy link
Author

Would it be easier to just insert the IP address in the database? I'm really interested in finding domains that suddenly start resolving to an IP addresses. Maybe create two columns, one for the date modified and then the IP. Would be cool to track if an IP address changes or just record changes, like it starts pointing to a CNAME but theres probably alot that are going to be load balanced and change IP addresses often...

@Edu4rdSHL
Copy link
Member

Edu4rdSHL commented Feb 28, 2020

It feature have been implemented in Findomain+ version. To know more about it see https://twitter.com/Edu4rdSHL/status/1229585761059721220?s=19

Proof: https://twitter.com/Edu4rdSHL/status/1233239614745391104?s=19

Edit: HTTP status also have been added to webhooks notifications.

@Edu4rdSHL Edu4rdSHL added implemented-in-plus-version Request for enhancement implemented in Findomain+. fixed Issue solved of feature request implemented. labels Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Issue solved of feature request implemented. implemented-in-plus-version Request for enhancement implemented in Findomain+. request-for-enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants