Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the library compatible with Instant Apps #50

Merged

Conversation

AndreasBoehm
Copy link
Contributor

Due to some restrictions applied to Instant Apps the fingerprint library crashes when the instance is created.

Adjustments:

  • check if externalStorageDir is readable before trying to access it, would crash otherwise
  • made DevicePolicyManager and KeyguardManager optional, would crash otherwise
  • remove unnecessary build version code check

@Alexey-Verkhovsky
Copy link
Member

Great changes! Thank you for highlighting the problem. ❤️ I merge it, and will release the changes in the version 1.2.1 in the nearest future.

@Alexey-Verkhovsky Alexey-Verkhovsky merged commit eefac97 into fingerprintjs:main Apr 12, 2022
@AndreasBoehm AndreasBoehm deleted the instant-app-adjustments branch April 12, 2022 09:07
@MarvinSchramm
Copy link

ez

@AndreasBoehm
Copy link
Contributor Author

Hi @Alexey-Verkhovsky could you let me know a rough ETA for release 1.2.1, we would really like to use this library in our Instant App.

@Alexey-Verkhovsky
Copy link
Member

Hey! If you mean changes that prevent crashes – you can integrate the library by sources, or as git submodule.
We plan to research instant app behaviour during the next week, so fixes and release will be after.

@AndreasBoehm
Copy link
Contributor Author

Hi @Alexey-Verkhovsky,

do you have an update on the ETA for a release that contains the Instant App fixes?
I don't want to mess around with submodules or compile my own version of the library to be honest.

@Alexey-Verkhovsky
Copy link
Member

Hi @AndreasBoehm! I released the new version with fixes you prepared, so just update version.

In your module, in the build.gradle file change
implementation "com.github.fingerprintjs:fingerprint-android:1.2" to
implementation "com.github.fingerprintjs:fingerprint-android:1.2.1"

@AndreasBoehm
Copy link
Contributor Author

Thanks a lot @Alexey-Verkhovsky !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants