Add AppInfoHarvester for collecting app-specific signals
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgutski
force-pushed
the
feature/user-interface-style-signal
branch
from
794ada0
to
6cf71ab
Compare
petrpalata
reviewed
Nov 23, 2022
petrpalata
reviewed
Nov 23, 2022
petrpalata
requested changes
Nov 23, 2022
The initial `AppInfoHarvester` implementation includes a single `userInterfaceStyle` property for retrieving the interface style for the app. The Light/Dark mode toggling was introduced in iOS 13, hence on iOS 12 the `userInterfaceStyle` property always returns `light` value.
mgutski
force-pushed
the
feature/user-interface-style-signal
branch
from
ea9294e
to
ce726e6
Compare
petrpalata
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial
AppInfoHarvesterimplementation includes a singleuserInterfaceStyleproperty for retrieving the interface style for the app.The Light/Dark mode toggling was introduced in iOS 13, hence on iOS 12 the
userInterfaceStyleproperty always returnslightvalue.