Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend the readme #852

Merged
merged 6 commits into from Jan 18, 2023
Merged

Amend the readme #852

merged 6 commits into from Jan 18, 2023

Conversation

Finesse
Copy link
Member

@Finesse Finesse commented Dec 21, 2022

  • Remove an unused image
  • Split the description from the accuracy note. I think it's important to have a simple answer to a "why may I need this" question. A single short paragraph is used for this.
  • Move a link to a React usage example from the Pro section to an OSS section. Also change the icon to an emoji resembling React logo.
  • Stick to the common file naming style
  • Add timestamps to the Pro response example
  • Hide a Pro response example under a spoiler, because it's bulky, and an example is already given on the Pro picture
  • Change "FingerprintJS Pro" to "Fingerprint Pro"

@Finesse Finesse requested review from Valve and makma December 21, 2022 13:52
@Finesse
Copy link
Member Author

Finesse commented Dec 23, 2022

@makma Do you want to take a look before I merge?

@makma
Copy link
Member

makma commented Jan 18, 2023

Thank you @Finesse, looks good to me.

@Finesse Finesse merged commit dd93f6b into master Jan 18, 2023
@Finesse Finesse deleted the hotfix/readme branch January 18, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants