-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal version number for scipy #13
Comments
From version 1.8.0 onwards, SciPy has made significant improvements to the sparse array implementation, it seems. Another good reason to define a minimal version number for scipy. |
That is a very good point. I'll be sure to take care of it in a moment. When I started the development, I had no idea which sparse package to use. I think I read an article about the new improvements in |
Thanks for taking care of this (a03e999). It is a very good thing that We have the luxury with PyFVTool of being able to 'simply' use a direct method for solving the sparse matrix equation using A few years ago, |
Unexpectedly, my conda package manager somehow downgraded the installed
scipy
package in my environment. I am not entirely sure why, but that is a different story.As a result of this accidental downgrade, I discovered that PyFVTool needs at least
scipy >= 1.8.0
, since it usesscipy.sparse.csr_array
which only became available in version 1.8.0.After upgrading (un-downgrading...?), I am now on scipy 1.11.2 and PyFVTool happily works again.
So better add this minimal version number to the requirements. I do not readily see where these are defined in the repo.
P.S. This happened when briefly exploring [
pytest_notebook
]. It was actually this package that unveiled the scipy version bug, so this tool seems to work for testing PyFVTool notebooks!The text was updated successfully, but these errors were encountered: