Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottomsheet view width issue when calling another view controller #46

Closed
osmansoykan opened this issue Mar 17, 2021 · 6 comments
Closed

Comments

@osmansoykan
Copy link

osmansoykan commented Mar 17, 2021

Hi,
There is a situation like this that I can not find the reason.
Call the bottom sheet screen like this and screenshot first:

    private lazy var bottomSheetTransitioningDelegate = BottomSheetTransitioningDelegate(
        contentHeights: [.bottomSheetAutomatic, 200 ],
        startTargetIndex: 0
    )
 let mViewcontroller = destination(.selectAccount) as! AccountListViewController
        mViewcontroller.contentHeight = 200
        mViewcontroller.transitioningDelegate = bottomSheetTransitioningDelegate
        mViewcontroller.modalPresentationStyle = .custom
        present(mViewcontroller, animated: true, completion: nil)

Screen Shot 2021-03-17 at 10 38 03

I call another viewController with the plus button.

      let mViewcontroller = destination(.createAccount) as! NewAccountViewController
        //mViewcontroller.modalPresentationStyle = .fullScreen
        self.present(mViewcontroller, animated: true, completion: nil)

When returning from the newaccount screen with dismiss, the bottom sheet screen looks like this:
Screen Shot 2021-03-17 at 10 29 41

It's okay if I don't call it with fullscreen. But when calling as fullscreen, bottomsheet view width changes and viewDidDisappear method is called.
I could not find the reason, I hope you can help.
Thanks a lot.

@sgmaturano
Copy link

Same error.

@sgmaturano
Copy link

@osmansoykan I fixed it using overfullscreen

@osanoj
Copy link
Contributor

osanoj commented May 28, 2021

Thanks for the help @sgmaturano 👍

@osanoj osanoj closed this as completed May 28, 2021
@oskarko
Copy link

oskarko commented Jun 17, 2021

The issue is not fixed yet at all, why do you close it @osanoj ?
I'm presenting a video-reward from AdMob SDK and I cannot set up the modalPresentationStyle property.

Any other alternative to avoid this glitch? Any real fix?

Thank you!

@osanoj
Copy link
Contributor

osanoj commented Jun 17, 2021

The issue is not fixed yet at all, why do you close it @osanoj ?
I'm presenting a video-reward from AdMob SDK and I cannot set up the modalPresentationStyle property.

Any other alternative to avoid this glitch? Any real fix?

Thank you!

Well, with a solution offered and no furter response in a while there is no reason to keep it open?

Are you having a similar issue @oskarko? Please create a new issue if you think it is a bug in the code, a link to a sample project where we can reproduce the problem will help you get more attention and quicker feedback.

Please note though that we provide this project to share what we are using in our apps and not to solve everyones need. If the problem you are having is not because of a bug but rather a missing feature or a different use-case (i.e. only an issue when using AdMob videos) I would suggest trying to solve it yourself and submitting a PR instead.

@oskarko
Copy link

oskarko commented Jun 17, 2021

Here you have @osanoj #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants