Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

153635973 Fix target=_blank security #157

Merged
merged 4 commits into from Dec 14, 2017

Conversation

K1ll3rF0x
Copy link
Contributor

@K1ll3rF0x K1ll3rF0x commented Dec 13, 2017

Improved linkify utility funktion (ote-ui.common)

  • Add additional security measures for target=_blank links
  • Allow relative paths to be "linkified"
  • Using linkify for relevant urls in the ote app.

From now on, if you add a new link, please use the linkify utility. Especially, if you want to open a new browser window for the link.

@K1ll3rF0x K1ll3rF0x changed the title 153635973 fix target blank security 153635973 Fix target=_blank security Dec 13, 2017
@K1ll3rF0x K1ll3rF0x requested review from tatut, rckopteri and a user December 13, 2017 15:09
Copy link
Contributor

@rckopteri rckopteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@tatut tatut merged commit 80eeb6f into master Dec 14, 2017
@tatut tatut deleted the 153635973-fix-target-blank-security branch December 14, 2017 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants