Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

153136675 info text #171

Merged
merged 8 commits into from Dec 19, 2017
Merged

153136675 info text #171

merged 8 commits into from Dec 19, 2017

Conversation

@rckopteri rckopteri requested review from tatut, K1ll3rF0x and a user December 15, 2017 12:52
@@ -225,7 +225,8 @@

:brokerage? "Jos kyseessä on Liikenteen turvallisuusvirasto Trafille ilmoitettava välityspalvelu, laita alle raksi."

:operation-area "Add the service operation area (for example province) by typing the name in the text field and selecting it from the list. You can also draw the area with the map drawing tools. You can name the area freely (like \"Itäkeskus taxi station\")."
:operation-area "Lisää toiminta-alue kirjoittamalla alueen tai kohteen nimi \"Hae paikka nimellä\" -tekstikenttään ja valitsemalla haluttu alue avutuvalta listalta (tällä hetkellä haettavissa maakunta, kunta, postinumero, Suomi). Voit samalla tavalla lisätä useita alueita.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix typo: "avutuvalta" -> "avautuvalta"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, thank you

"guaranteed-info-service-accessibility" "Guaranteed info service accessibility"
"guaranteed-transportable-aid" "Guaranteed transportable aid"
"guaranteed-vehicle-accessibility" "Guaranteed vehicle accessibility"
"limited-accessibility-description" "Limited availability accessibility description"
"limited-accessibility-description" "Kerro tarvittaessa lisätietoja rajoitetusti saatavilla olevista esteettömyyspalveluista"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This input header is so long, that is getting on the input field:
image
I think we should increase the initial rows amount of free text fields to be bigger than one row.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave these ui issues to Jussi

# Conflicts:
#	ote/resources/public/language/sv.edn
@@ -225,7 +225,8 @@

:brokerage? "Jos kyseessä on Liikenteen turvallisuusvirasto Trafille ilmoitettava välityspalvelu, laita alle raksi."

:operation-area "Add the service operation area (for example province) by typing the name in the text field and selecting it from the list. You can also draw the area with the map drawing tools. You can name the area freely (like \"Itäkeskus taxi station\")."
:operation-area "Lisää toiminta-alue kirjoittamalla alueen tai kohteen nimi \"Hae paikka nimellä\" -tekstikenttään ja valitsemalla haluttu alue avautuvalta listalta (tällä hetkellä haettavissa maakunta, kunta, postinumero, Suomi). Voit samalla tavalla lisätä useita alueita.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why replace English translated text with Finnish? Translate message. (same for all messages in en.edn file)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Koska teksti muuttuu ja meillä ei taida olla vielä missään virallista englantia?
Otanko kaikki muutokset pois tästä tiedostosta?

@tatut tatut merged commit 3163306 into master Dec 19, 2017
@tatut tatut deleted the 153136675-info-text branch December 19, 2017 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants