Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load external content with Wildcard and nested navigation #41

Closed
adimkov opened this issue Oct 7, 2012 · 4 comments
Closed

Load external content with Wildcard and nested navigation #41

adimkov opened this issue Oct 7, 2012 · 4 comments
Assignees
Labels
Milestone

Comments

@adimkov
Copy link
Contributor

adimkov commented Oct 7, 2012

Firstly, thanks for your job, it's good idea and implementation.

I'm trying to implement following scenario:

in the main page only one "navigation node"

<div data-bind='page: {id: '?', sourceOnShow: '{1}.html'}'><div>

each loaded element have own navigation... for example into modal view.

Problems:

  1. after recent update external sources not loading into main page, but loaded after page refresh. Url is changed, but nothing happens
  2. nested navigation doesn't work. Url is changing, but nothing happens.

Maybe it's wrong way, but looks like it's should work.

thanks.

@finnsson
Copy link
Owner

finnsson commented Oct 7, 2012

Thanks for the bug report. There is obviously some scenario I have missed among my tests.

Could you send a minimal setup that still fails?

I'm testing (test/should_send_wildcard_id_on_load.html)

<div data-bind="page: {id: '?', sourceOnShow: '../test-data/{1}.html'}">
</div>

and in the js code

location.hash = "#ipsum";

var viewModel = {
};

pager.extendWithPage(viewModel);
ko.applyBindings(viewModel);

pager.start(viewModel);

and it seems to work. Maybe there is some combination of properties that I haven't handled?

Are you "deep loading" (e.g. loading /foo/bar.html) content? If so, are you specifying deep: true (see Deep Loading Content ).

Which dist (pager.amd.min.js, pager.min.js, ...) are you using? Which browser(s)?

@ghost ghost assigned finnsson Oct 7, 2012
@adimkov
Copy link
Contributor Author

adimkov commented Oct 7, 2012

I have prepared new test to reproduce the problem

Actually, I can send it as push request.

@finnsson
Copy link
Owner

finnsson commented Oct 7, 2012

Excellent. Send it as a push request.

I have an idea what the problem might be. Pagerjs used to run beforeShow/showElement/afterShow to often previously. The problem is probably that it is triggered to few times now. Didn't consider wildcards...

@finnsson
Copy link
Owner

finnsson commented Oct 7, 2012

WIldcards are fixed (for now). Thanks for the test and good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants