Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open API Test Cases #18

Closed
6 tasks
robmoffat opened this issue Jun 9, 2022 · 3 comments
Closed
6 tasks

Open API Test Cases #18

robmoffat opened this issue Jun 9, 2022 · 3 comments

Comments

@robmoffat
Copy link
Member

robmoffat commented Jun 9, 2022

A Opens B

  • AOpensB1: [ ] A calls fdc3.open(‘app B Name’), check app B opens
  • AOpensB1: [ ] A calls fdc3.open({name: “<app B Name>”}), check app B opens
  • AOpensB1: [ ] A calls fdc3.open({name: “<app B Name>”, appId: “<app B ID”}), check app B opens
  • AOpensB1: [ ] A calls {appID: “<app ID>”}, check app **B** opens. (FDC3 2.0`)

A Fails To Open B

A Opens B With Context

App Step Description
A Opening App various open methods as in AOpensB1 except with a <context> argument
check app opens
B Context present fdc3.addContextListener()
- receives <context> from A
  • AOpensBWithContext: Perform above tests
  • AOpensBWithSpecificContext: Perform above but replace Bs call with fdc3.addContextListener('fdc3.instrument)`

Specific Context

App Step Description
A Opening App fdc3.open(‘app Name’, <contact context>)
check app opens
B Context present fdc3.addContextListener()
- receives from a
A Promise - receives a rejection from the open promise with “App Timeout’ from
https://fdc3.finos.org/docs/api/ref/Errors#openerror
  • AOpensBWithWrongContext: As above
  • AOpensBNoListen: Skip `fdc3.addContextListener() above.
  • AOpensBMultipleListen: B performs fdc3.addContextListener('fdc3.instrument') prior to the existing addContextListener`. The correct context listener should receive the context, and the promise completes successfully
  • AOpensBMalformedContext: A tries to pass malformed context to B. Context listener receives nothing, promise completes successfully.
@robmoffat robmoffat mentioned this issue Jun 9, 2022
14 tasks
@osouthwell-scottlogic
Copy link
Contributor

@robmoffat Hi, is it possible to have this issue assigned to me?

@ColinEberhardt
Copy link
Contributor

This has been partially implemented in #49 - we do have a big obstacle, how do you verify that a given app was opened and (optionally) context received. We'll look into various ways we can confirm this in an automated fashion.

@ColinEberhardt
Copy link
Contributor

We now verify the communication from app to mock-app, via #51 - so this issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants