Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKS - Terraform #113

Merged
merged 5 commits into from May 17, 2021
Merged

EKS - Terraform #113

merged 5 commits into from May 17, 2021

Conversation

@abdullahgarcia
Copy link
Contributor

@abdullahgarcia abdullahgarcia commented Apr 8, 2021

The following files have been reviewed, but there are several files still pending to be added as I'm currently reviewing them.

The following files have been reviewed, but there are several files still pending to be added as I'm currently reviewing them.
@abdullahgarcia abdullahgarcia self-assigned this Apr 8, 2021
@abdullahgarcia abdullahgarcia linked an issue that may be closed by this pull request Apr 8, 2021
2 of 4 tasks
@mcleo-d mcleo-d added this to To do in Cloud Service Certification via automation Apr 8, 2021
@mcleo-d mcleo-d moved this from To do to In progress in Cloud Service Certification Apr 8, 2021
These files enable the creation of the EKS cluster accordingly. There is room for improvement which will be reflected in upcoming commits/pull requests.
@mcleo-d
Copy link
Member

@mcleo-d mcleo-d commented Apr 22, 2021

Please say hello here if you would like to review 👋

@mcleo-d mcleo-d moved this from In progress to Sprint 2 in Cloud Service Certification Apr 22, 2021
@mcleo-d mcleo-d mentioned this pull request Apr 22, 2021
2 of 4 tasks
@abdullahgarcia abdullahgarcia changed the title EKS - Terraform - First Files EKS - Terraform Apr 26, 2021
@abdullahgarcia
Copy link
Contributor Author

@abdullahgarcia abdullahgarcia commented Apr 26, 2021

Please say hello here if you would like to review 👋

James, do we know who volunteered for reviewing the pull request? That way we can add that person to the reviewers list.

@mcleo-d
Copy link
Member

@mcleo-d mcleo-d commented Apr 28, 2021

Hi @njwilliams 👋

I'm unable to add you to the reviewers list, but it would be great if you could review this PR as discussed in #114 for @abdullahgarcia so we can accept and potentially merge in Sprint 2.

I have also asked the CSC community for help in the FINOS CSC Slack - https://finos-lf.slack.com/archives/C01RNUMC2DP/p1619609764075100

Thanks for your help.

James 🚀

Copy link
Contributor

@peterrhysthomas peterrhysthomas left a comment

This looks good to me, it would be good to get a comparison of this versus the GKE for Azure and GCP so if @TLATER or @alfredtommy to see if there is anything they think of note - @mcleo-d will create a new issue for enhancements to this which can be used for anything we would like to add afterwards.

@abdullahgarcia abdullahgarcia merged commit 4f27e05 into finos:master May 17, 2021
1 check passed
1 check passed
@finos-cla-bot
verification/cla-signed
Details
Cloud Service Certification automation moved this from Ready for Review to Done May 17, 2021
@abdullahgarcia abdullahgarcia deleted the abdullahgarcia:eks-terraform branch May 17, 2021
@mcleo-d
Copy link
Member

@mcleo-d mcleo-d commented May 17, 2021

@abdullahgarcia and @peterrhysthomas,

Issue #123 has been raised to carry this contribution forward with the CSC and wider OSS community.

Congratulations once again!

James 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

3 participants