Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password-hash is deprecated, use bcrypt or scrypt instead #454

Closed
maoo opened this issue Feb 27, 2024 · 3 comments
Closed

Password-hash is deprecated, use bcrypt or scrypt instead #454

maoo opened this issue Feb 27, 2024 · 3 comments
Assignees
@JamieSlome
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers security Security improvements or tooling

Comments

@maoo
Copy link
Member

maoo commented Feb 27, 2024

See https://www.npmjs.com/package/password-hash

Password-hash is used in:

  • /src/db/index.js
  • /src/service/passport/local.js
@maoo maoo added good first issue Good for newcomers dependencies Pull requests that update a dependency file security Security improvements or tooling labels Feb 27, 2024
@maoo maoo mentioned this issue Feb 27, 2024
Closed
This was referenced Feb 27, 2024
Closed
Closed
@coopernetes coopernetes mentioned this issue Mar 25, 2024
Merged
@marksmith388
Copy link

Hi, I'd like to be assigned this issue

@JamieSlome
Copy link
Member

Hey @marksmith388 - this will be addressed in #335 👍

Apologies for not updating this ticket.

Welcome nonetheless and thanks for dropping a comment ❤️

@JamieSlome
Copy link
Member

Addressed in #335. Closing this issue 👍

@JamieSlome JamieSlome self-assigned this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamieSlome JamieSlome

Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers security Security improvements or tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

changed password hash to bcrypt fixes #454 singhotto/git-proxy
3 participants
@maoo @JamieSlome @marksmith388