Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation and usage instructions do not load the user interface ⚡ #570

Closed
JamieSlome opened this issue May 21, 2024 · 6 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@JamieSlome
Copy link
Member

Describe the bug
A clear and concise description of what the bug is.

When following the installation and usage instructions, the proxy and service start as expected:

Proxy Listening on 8000
Service Listening on 8080

However, when navigating to the UI (http://localhost:8080), the following error is presented in the browser:

Error: ENOENT: no such file or directory, stat '/Users/jamie/.nvm/versions/node/v20.3.1/lib/node_modules/@finos/git-proxy/build/index.html'

To Reproduce
Steps to reproduce the behavior:

  1. npm install -g @finos/git-proxy@1.2.1
  2. Run git-proxy from a terminal or command line
  3. Visit localhost:8080
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

When visiting localhost:8080 we should expect to see the main dashboard page appearing:

Screenshot 2024-05-21 at 15 31 55

Desktop (please complete the following information):

  • OS: Mac
  • Browser: Chrome
  • Version: @finos/git-proxy@1.2.1
@JamieSlome JamieSlome added the bug Something isn't working label May 21, 2024
@JamieSlome
Copy link
Member Author

@tt-gideonaryeetey, @divinetettey - are you interested in picking this one up? 👍

@tt-gideonaryeetey
Copy link
Contributor

@JamieSlome Yes! I'll take care of it. Please assign it to me.

@JamieSlome
Copy link
Member Author

@tt-gideonaryeetey - since merging #575 and release in #577, it appears that the issue remains? Can you verify?

@tt-gideonaryeetey
Copy link
Contributor

tt-gideonaryeetey commented May 23, 2024

@JamieSlome The issue remains. It appears the build directory was ignored by the npm registry. We need to add an empty .npmignore file to override .gitignore. That way the build directory would not be ignored.
I will do that and create a PR. Thanks!
Reference here

@JamieSlome
Copy link
Member Author

@tt-gideonaryeetey - it looks like we've hit the moon 🚀 🌔 Great job!

Can you confirm on your side? I'll close this issue as completed once I hear back.

@tt-gideonaryeetey
Copy link
Contributor

@tt-gideonaryeetey - it looks like we've hit the moon 🚀 🌔 Great job!

Can you confirm on your side? I'll close this issue as completed once I hear back.

Nice! It's working for me too. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants