Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround typescript-eslint lack of support for Typescript project reference #500

Closed
Tracked by #83
akphi opened this issue Sep 15, 2021 · 1 comment
Closed
Tracked by #83
Labels
Studio Core Team Opened by a member of the Studio core team Type: Maintenance DevOps, maintenance, admin works to do with the repository

Comments

@akphi
Copy link
Contributor

akphi commented Sep 15, 2021

typescript-eslint: Support for Typescript project reference is still lacking, causing OOM when running on whole project. The suggested workaround right now is to break down the project eslint process into one process per workspace, which makes our scripts section rather verbose in each workspace package.json. See typescript-eslint/typescript-eslint#2094.

Regarding the lint check in pre-commit phase, we cannot really bypass this, and will once-in-a-while bump into OOM issue 😢, so it's probably best that we turn off this check during pre-commit phase (done in #495)


This is extracted from the umbrella tracker for dependencies #83
We will close this once we found that @typescript-eslint has a more solid support for project reference

@akphi akphi added Studio Core Team Opened by a member of the Studio core team Type: Enhancement labels Sep 15, 2021
@akphi akphi changed the title Workaround ESLint lack of support for Typescript project reference Workaround typescript-eslint lack of support for Typescript project reference Sep 15, 2021
This was referenced Sep 15, 2021
@akphi akphi added Type: Maintenance DevOps, maintenance, admin works to do with the repository and removed Type: Enhancement labels Oct 28, 2021
@akphi
Copy link
Contributor Author

akphi commented Nov 18, 2021

I will close this issue just because we no longer see the need in having eslint running at top level of the monorepo, rather, we can have it running locally for each project. Also, since we remove eslint as part of lint-staged for more agile development process. I don't think we need to watch this anymore

@akphi akphi closed this as completed Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Studio Core Team Opened by a member of the Studio core team Type: Maintenance DevOps, maintenance, admin works to do with the repository
Projects
None yet
Development

No branches or pull requests

1 participant