Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Involvement: cannot bulk load for Change Initiatives #6460

Closed
davidwatkins73 opened this issue Feb 24, 2023 · 2 comments
Closed

Involvement: cannot bulk load for Change Initiatives #6460

davidwatkins73 opened this issue Feb 24, 2023 · 2 comments
Assignees
Labels
bug Defect affecting the currently released version of Waltz fixed (test & close) An issue has been fixed, merged into master and is ready for further testing
Milestone

Comments

@davidwatkins73
Copy link
Member

Description

Attempting to bulk load involvements gives an error:

image

14:19:31.219 [qtp1440558136-19] ERROR org.finos.waltz.web.Main - Illegal Argument Exception: Cannot find lookup map for id for entity kind: CHANGE_INITIATIVE
java.lang.IllegalArgumentException: Cannot find lookup map for id for entity kind: CHANGE_INITIATIVE
	at org.finos.waltz.data.EntityAliasPopulator.fetchEntityIdLookupMap(EntityAliasPopulator.java:61)
	at org.finos.waltz.service.bulk_upload.BulkUploadService.resolveInvolvements(BulkUploadService.java:141)
	at org.finos.waltz.service.bulk_upload.BulkUploadService.resolve(BulkUploadService.java:56)
	at org.finos.waltz.web.endpoints.api.BulkUploadEndpoint.resolveRoute(BulkUploadEndpoint.java:81)
	at org.finos.waltz.web.endpoints.EndpointUtilities.lambda$wrapListHandler$0(EndpointUtilities.java:100)
	at spark.ResponseTransformerRouteImpl$1.handle(ResponseTransformerRouteImpl.java:47)
	at spark.http.matching.Routes.execute(Routes.java:61)
       ...snip...
	at java.lang.Thread.run(Thread.java:748)

Waltz Version

1.47

Steps to Reproduce

Upload a sample file to the bulk invovlement editor

Expected Result

Involvements are created

Actual Result

Error thrown

@davidwatkins73 davidwatkins73 added the bug Defect affecting the currently released version of Waltz label Feb 24, 2023
@davidwatkins73 davidwatkins73 added this to the 1.47.2 milestone Feb 24, 2023
@davidwatkins73 davidwatkins73 self-assigned this Feb 24, 2023
@davidwatkins73
Copy link
Member Author

davidwatkins73 commented Feb 24, 2023

Fails for Org units too.

Tasks:

  • fix for CI
  • fix for OU

@davidwatkins73
Copy link
Member Author

Some stuff for test data generation:



-- first needed to set some ext ids on the demo org unit table
    
-- update organisational_unit set external_id = concat('OU_', id);


-- generate junk ou involvements
select ou.external_id, p.email
from organisational_unit ou
cross join person p
where p.id = ou.id
limit 100;

-- generate junk ci involvements
select ci.external_id, p.email
from change_initiative ci
         cross join person p
where p.id = ci.id
limit 100;


-- generate junk app involvements
select app.asset_code, p.email
from application app
         cross join person p
where p.id = app.id
limit 100;

@davidwatkins73 davidwatkins73 added the waiting on contribution Issue has been fixed, however the code has not _yet_ made it's way upstream label Feb 24, 2023
@davidwatkins73 davidwatkins73 added fixed (test & close) An issue has been fixed, merged into master and is ready for further testing and removed waiting on contribution Issue has been fixed, however the code has not _yet_ made it's way upstream labels Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defect affecting the currently released version of Waltz fixed (test & close) An issue has been fixed, merged into master and is ready for further testing
Projects
None yet
Development

No branches or pull requests

1 participant