Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Vendor-ID (10415) for AVP 334, 486, 493 in S6A dictionary #105

Closed
rdcloyi opened this issue Jan 23, 2019 · 3 comments
Closed

Incorrect Vendor-ID (10415) for AVP 334, 486, 493 in S6A dictionary #105

rdcloyi opened this issue Jan 23, 2019 · 3 comments

Comments

@rdcloyi
Copy link

rdcloyi commented Jan 23, 2019

The AVP 334, 486 and 493 are used by 3GPP S6A but actually defined in RFC 4004,5447 and 5778. So Vendor-ID of them should be zero instead of 10415. According to this link https://www.developingsolutions.com/DiaDict/Dictionary/Service-Selection.html, it clearly defines vendor ID 0 for AVP 493. Not sure if you agree to update the dictionary.

@fiorix
Copy link
Owner

fiorix commented Feb 5, 2019

I wonder what most vendors do, and what would break if we update the dictionary.

@rdcloyi
Copy link
Author

rdcloyi commented Mar 22, 2019

I am working for Ericsson. At least in my context, it uses vendor ID 0. I had to change it locally to pass my test. For other vendors, I don't know.

@fiorix
Copy link
Owner

fiorix commented Jul 13, 2019

If you send a PR we'll review. Can't think of any other action here.

@fiorix fiorix closed this as completed Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants