dealing with some edge cases and documenting the new WATCH functionality #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch deals with the following scenarios, which would ended up
cleaning the inTransaction prematurely:
1. UNWATCH after MULTI
t = multi
t.unwatch
2. WATCH, MULTI (with keys)
t = watch
t.multi("foobar")
t.unwatch
3 . MULTI + WATCH
t = multi
t.watch # this is invalid, but
will change the _unwatch_cc
to a function that would clear
the inTransaction state
I've also dropped a couple more tests, notably testing WATCH with ConnectionPool.
|
Probably these cases will never show up in production code, but better fix them before ruining someones day :-) |
gleicon
added a commit
that referenced
this pull request
Dec 21, 2012
dealing with some edge cases and documenting the new WATCH functionality
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch deals with the following scenarios, which would ended up
cleaning the inTransaction prematurely:
UNWATCH after MULTI
t = multi
t.unwatch
WATCH, MULTI (with keys)
t = watch
t.multi("foobar")
t.unwatch
3 . MULTI + WATCH
t = multi
t.watch # this is invalid, but
will change the _unwatch_cc
to a function that would clear
the inTransaction state
I've also dropped a couple more tests, notably testing WATCH with ConnectionPool.