Fixed reconnect=False, broken by 5469ca1b #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaSkriblovsky
added a commit
that referenced
this pull request
Jan 13, 2016
Fixed reconnect=False, broken by 5469ca1
|
Took courage to merge this by myself because it seems urgent to me: broken 1.4 version was released :-( |
|
@fiorix Could you please upload fixed 1.4.1 to PyPI? |
|
Done! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I broke
reconnect=Falseparameter of Connections by my previous commit c64c810It turns out that
continueTryingis overloaded to implement one-shot connections and for them it is alwaysFalse.Sorry :(