wsdl2go issues

[Fank]

wsdl: http://soap.brokerbin.com/brokerbin_search/search.wsdl

Cut from generated go file:

// NewHandleSearchPort creates an initializes a HandleSearchPort.
func NewHandleSearchPort(cli *soap.Client) HandleSearchPort {
	return &handleSearchPort{cli}
}

// HandleSearchPort was auto-generated from WSDL
// and defines interface for the remote service. Useful for testing.
type HandleSearchPort interface {
}

// handleSearchPort implements the HandleSearchPort interface.
type handleSearchPort struct {
	cli *soap.Client
}

// Authenticate was auto-generated from WSDL.
func (p *handleSearchPort) Authenticate(α string, reqPassword string, reqOptions interface{}) (β string, err error) {
	γ := struct {
		XMLName xml.Name `xml:"Envelope"`
		Body    struct {
			M string `xml:"string"`
		}
	}{}
	if err = p.cli.RoundTripWithAction("Authenticate", α, &γ); err != nil {
		return "", err
	}
	return γ.Body.M, nil
}

// Search was auto-generated from WSDL.
func (p *handleSearchPort) Search(α interface{}, reqOptions interface{}) (β interface{}, err error) {
	γ := struct {
		XMLName xml.Name `xml:"Envelope"`
		Body    struct {
			M interface{} `xml:"interface{}"`
		}
	}{}
	if err = p.cli.RoundTripWithAction("Search", α, &γ); err != nil {
		return nil, err
	}
	return γ.Body.M, nil
}

HandleSearchPort is empty which causes:

Authenticate and Search will only transport first parameter e.g. for Authenticate:

POST / HTTP/1.1
Host: localhost
Content-Type: text/xml
Soapaction: urn:HandleSearch/Authenticate

<SOAP-ENV:Envelope xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/" xmlns:ns="urn:HandleSearch" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"><SOAP-ENV:Body><Message>foo</Message></SOAP-ENV:Body></SOAP-ENV:Envelope>

Expected or needed request for linked wsdl above:

POST / HTTP/1.1
Host: localhost
Content-Type: text/xml
Soapaction: urn:HandleSearch/Authenticate

<soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"  xmlns:tns="urn:HandleSearch">
	<soap:Body>
		<tns:Authenticate>
			<reqUsername>foo</reqUsername>
			<reqPassword>:)</reqPassword>
		</tns:Authenticate>
	</soap:Body>
</soap:Envelope>

The main difference is that Message (in first) is replaced by a "message" tns:Authenticate (in second) which also contains reqUsername (aka α) and reqPassword (aka reqPassword).

Got same issues for other wsdl files, but this is the easiest example, to explain.

[Fank]

Working example one:

type AuthenticateResponse struct {
	ResSession string `xml:"resSession,omitempty" json:"resSession,omitempty" yaml:"resSession,omitempty"`
}

func (p *handleSearchPort) Authenticate(reqUsername string, reqPassword string, reqOptions interface{}) (β AuthenticateResponse, err error) {
	α := struct {
		XMLName     xml.Name    `xml:"tns:Authenticate"`
		ReqUsername string      `xml:"reqUsername,omitempty"`
		ReqPassword string      `xml:"reqPassword,omitempty"`
		ReqOptions  interface{} `xml:"reqOptions,omitempty"`
	}{
		ReqUsername: reqUsername,
		ReqPassword: reqPassword,
		ReqOptions:  reqOptions,
	}
	γ := struct {
		XMLName xml.Name `xml:"Envelope"`
		Body    struct {
			M AuthenticateResponse `xml:"AuthenticateResponse"`
		}
	}{}
	if err = p.cli.RoundTripWithAction("Authenticate", α, &γ); err != nil {
		return AuthenticateResponse{}, err
	}
	return γ.Body.M, nil
}

Working example two (which i prefer):

type AuthenticateRequest struct {
	XMLName     xml.Name    `xml:"tns:Authenticate"`
	ReqUsername string      `xml:"reqUsername,omitempty" json:"reqUsername,omitempty" yaml:"reqUsername,omitempty"`
	ReqPassword string      `xml:"reqPassword,omitempty" json:"reqPassword,omitempty" yaml:"reqPassword,omitempty"`
	ReqOptions  interface{} `xml:"reqOptions,omitempty" json:"reqOptions,omitempty" yaml:"reqOptions,omitempty"`
}

type AuthenticateResponse struct {
	ResSession string `xml:"resSession,omitempty" json:"resSession,omitempty" yaml:"resSession,omitempty"`
}

func (p *handleSearchPort) Authenticate(α AuthenticateRequest) (β AuthenticateResponse, err error) {
	γ := struct {
		XMLName xml.Name `xml:"Envelope"`
		Body    struct {
			M AuthenticateResponse `xml:"AuthenticateResponse"`
		}
	}{}
	if err = p.cli.RoundTripWithAction("Authenticate", α, &γ); err != nil {
		return AuthenticateResponse{}, err
	}
	return γ.Body.M, nil
}

I don't know anything about soap or xml communication in general, i only try to rebuild the communication from a existing perl application to go.
It would be nice if the wsdl2go would generate such code, but don't know if it will break other communications.

[fiorix]

Hey, this is what the header field in soap.Client is for.

When you instantiate your Client, you can set its Header to any struct that you want, for example your AuthenticateRequest. When a Header is present, it'll be included in all requests issued by the client.

[Fank]

I think you missunderstood the issue, i was talking about the wsdl2go converting.
Because the body which was generated is not as expected, there is no issue with the header, there are issues with the body.

[fiorix]

Oops. This is definitely something else.

[fiorix]

Tracking in #74.

[kernle32dll]

@Fank @fiorix I figured out whats the problem (at least for the wrong structure - for parameters not beeing used see #74 ). The problem is, that wsdl2go does not correctly honor the style="rpc" part in the soap:binding. The rpc style means, that parameters of a operation have to be wrapped by an XML element of the operation name.

See here for examples and implications:
https://www.ibm.com/developerworks/library/ws-whichwsdl/

I will issue a PR to fix this.