Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crashes in zlib.js #149

Closed
fippo opened this issue Jul 6, 2016 · 4 comments
Closed

crashes in zlib.js #149

fippo opened this issue Jul 6, 2016 · 4 comments

Comments

@fippo
Copy link
Owner

fippo commented Jul 6, 2016

the major remaining crash is in zlib.js line 623 which is this code:

      var newReq = self._handle.write(flushFlag,
                                      chunk,
                                      inOff,
                                      availInBefore,
                                      self._buffer,
                                      self._offset,
                                      self._chunkSize);

self._handle is null:

zlib.js:623
      var newReq = self._handle.write(flushFlag,
                               ^

TypeError: Cannot read property 'write' of null
    at Zlib.callback (zlib.js:623:32)

It is in the process that handles websockets so I suspect the websocket closes in the middle of things. Sounds like a bug in node-core...

@fippo
Copy link
Owner Author

fippo commented Jul 6, 2016

@ggarber @dagingaa thoughts? Who do we know that can debug node shit...

@dagingaa
Copy link

dagingaa commented Jul 7, 2016

Honestly I would open an issue for it for now, perhaps someone knows outside us?

@fippo
Copy link
Owner Author

fippo commented Jul 7, 2016

might be fixed by nodejs/node#5982 / nodejs/node#6034
-- i'll see if I can monkeypatch it on our instance

@fippo
Copy link
Owner Author

fippo commented Jul 12, 2016

hrm. This seems to be fixed. Or now it always crashes before running into this.

@fippo fippo closed this as completed Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants