Conversation
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
- Coverage 83.40% 83.38% -0.02%
==========================================
Files 15 20 +5
Lines 223 295 +72
Branches 31 44 +13
==========================================
+ Hits 186 246 +60
- Misses 29 40 +11
- Partials 8 9 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Исправь для начала, пожалуйста, создание документации.
/autodonate/checkouts/16/autodonate/lib/payment/models.py:docstring of autodonate.lib.payment.models.PaymentService.pinging:1: WARNING: duplicate object description of autodonate.lib.payment.models.PaymentService.pinging, other instance in modules/autodonate.lib.payment.models, use :noindex: for one of them
/autodonate/checkouts/16/autodonate/lib/payment/models.py:docstring of autodonate.lib.payment.models.PaymentService.ping_interval:1: WARNING: duplicate object description of autodonate.lib.payment.models.PaymentService.ping_interval, other instance in modules/autodonate.lib.payment.models, use :noindex: for one of them
/autodonate/checkouts/16/autodonate/lib/payment/models.py:docstring of autodonate.lib.payment.models.PaymentService.logo_path:1: WARNING: duplicate object description of autodonate.lib.payment.models.PaymentService.logo_path, other instance in modules/autodonate.lib.payment.models, use :noindex: for one of them
/autodonate/checkouts/16/autodonate/lib/payment/models.py:docstring of autodonate.lib.payment.models.PaymentService.name:1: WARNING: duplicate object description of autodonate.lib.payment.models.PaymentService.name, other instance in modules/autodonate.lib.payment.models, use :noindex: for one of them
@PerchunPak проблема доков не моя проблема, что они пытаются 2 раза заиндексить одно и то же. Они собираются, что ещё не хватает? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Посмотрел на ошибки сборки документации, исправления почти не повлияют на код.
RUB = 0 | ||
UAH = 1 | ||
USD = 2 | ||
EUR = 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не понял что и куда переписать.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Запись атрибутов в __init__
метод.
Правильно:
class A:
def __init__(self):
self.a = "a"
self.b = "b"
Как ты делаешь:
class A:
a = "a"
b = "b"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Документация с тобой не согласна. И может объяснишь почему это "неправильно"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Поставить флаг unique
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не решено, как я отметил в самом первом комментарие, это относиться и к другим 4 предупреждениям из за которых документация проваливается
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
И если отменить b799cdb это вернет ошибку, декоратор unique
не помог.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
И если отменить b799cdb это вернет ошибку, декоратор
unique
не помог.
unique нужен для предотвращения ошибок в базе данных. Он и не должен был решить проблему с доками.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тогда почему ты написал что решил?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тогда почему ты написал что решил?
Потому что там был коммент с todo)
@PerchunPak удали те файлы на которые жалуется дока из индекса |
И вообще это очень странно, откуда он там нашел |
(cherry picked from commit 264e39d)
Resolves #15