Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoClassDefFoundErrors logcat spam for optional providers #1200

Closed
wojtek-kalicinski opened this issue Mar 22, 2018 · 2 comments
Closed

NoClassDefFoundErrors logcat spam for optional providers #1200

wojtek-kalicinski opened this issue Mar 22, 2018 · 2 comments

Comments

@wojtek-kalicinski
Copy link

  • Android device: Pixel 2
  • Android OS version: P
  • Google Play Services version:
  • Firebase/Play Services SDK version:
  • FirebaseUI version: 3.2.2

Step 3: Describe the problem:

ART verification spams the logcat with NoClassDefFoundErrors, because it needs to resolve superclasses of TwitterProvider and FacebookProvider, which don't exist if you're not using these SDKs.

Instead of extending/implementing Callbacks from the SDKs directly, these classes should have inner classes for callbacks, that will not be eagerly verified.

Steps to reproduce:

  1. Don't include Facebook and Twitter SDKs
  2. Try to sign in using Firebase Auth

Observed Results:

NoClassDefFoundErrors in logcat

Expected Results:

No errors

@samtstern
Copy link
Contributor

@SUPERCILEX integrated your suggestions into #1189

@samtstern
Copy link
Contributor

This issue has been fixed and released in 3.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants