Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTP not fill in PhoneAuth #775

Closed
naveengoyal1993 opened this issue Sep 20, 2019 · 31 comments · Fixed by #837
Closed

OTP not fill in PhoneAuth #775

naveengoyal1993 opened this issue Sep 20, 2019 · 31 comments · Fixed by #837

Comments

@naveengoyal1993
Copy link

I am using the FirebaseUI for Phone Auth. OTP message does not fill the keyboard autofill suggestion box. OTP Code fill view (FUICodeField) does not appear the suggestion box in a keyboard. I have shared the screenshot link for this issue.
firebase-auth

Please help me to resolve this issue.

Env:
Lib: Firebase (v6.8.1), FirebaseAuth (v6.2.3), FirebaseCore (v6.2.3) and FirebaseUI (v8.1.0).
Deployment Target set to iOS 12.3.
iPhone 6 (v12.4.1).

Originally posted by @naveengoyal1993 in #515 (comment)

@artmatsak
Copy link

@morganchen12 That doesn't work for me either, any suggestions please? Deployment target is iOS 12.1.

IMG-0597

@alex-vasenin
Copy link

Doesn't work for me either (iOS 13), despite FUICodeField implements proper textContentType

@ninja342
Copy link

ninja342 commented Dec 3, 2019

Same issue

@sfoulston
Copy link

Experiencing the same issue here

@vmkcom
Copy link

vmkcom commented Dec 5, 2019

Same issue for me

@qubblr
Copy link

qubblr commented Dec 5, 2019

Same issue here

@alex-vasenin
Copy link

Any updates on this?

@morganchen12 morganchen12 self-assigned this Dec 20, 2019
@nikitaame
Copy link

Would love to see this resolved to better our user's sign-in and sign-up process :)

@WestyHopkins
Copy link

It would be incredible if you could please fix this - it's a small thing but it makes sign-up much more seamless for our users. Thanks!

@dtran320
Copy link

👍 on this. Likely going to have to implement our own signup screen instead of using the authUI phoneNumber one until this is resolved.

@dtran320
Copy link

dtran320 commented Feb 21, 2020

Hmm, I'm confused— https://github.com/firebase/FirebaseUI-iOS/pull/516/files#r217218746 looks like it would fix this, but I don't see that code in FUICodeField.m

Edit: It looks like this actually got reversed in a420bf4#diff-2daaff917914e08930fc2cb9335deca1

@morganchen12 Are y'all still looking for someone to implement this in a way that would fallback gracefully for older versions?

@morganchen12
Copy link
Contributor

Hey @dtran320, I've been meaning to take care of it for a while but haven't found the time. I'm happy to review a PR, otherwise I will try to get to it soon.

Sorry for the delay everyone.

@morganchen12
Copy link
Contributor

This fix has been released.

@naveengoyal1993
Copy link
Author

Still, this fix is not working for me.
Env:
Lib: FirebaseAuth (v6.18.0), FirebaseCore (v6.6.3) and FirebaseUI (v8.4.2).
Xcode Version: 11.3.1
iPhone 6 (v12.4.5).

@dtran320
Copy link

dtran320 commented Mar 4, 2020

OTP doesn't appear for me either using FirebaseAuth (v6.18.0), FirebaseCore (v6.6.3) and FirebaseUI (v8.4.2) as well with iPhone 11 Pro (iOS 13). Funnily enough, it does appear when entering your phone number.

firebaseauth_otp
firebaseauth

@morganchen12 morganchen12 reopened this Mar 4, 2020
@morganchen12
Copy link
Contributor

Hey all, after testing this again, I'm unable to figure out why the one time passcode is presented on the phone number entry screen but not the code entry screen. When profiling the code, the method fetching the traits from the code entry view isn't called until it's presented, but it's somehow having an effect on the screen before it.

I'll continue to try to debug this and if I don't reach a conclusion I'll file some feedback to Apple.

@willbattel
Copy link

willbattel commented Apr 4, 2020

I'm sure this isn't news to you since we're using the same version as everyone else here, but just for the record: we've just implemented PhoneAuth in our app and are experiencing this same thing. The OTP does not appear as an auto-fill suggestion until after starting the auth process a second time, where it appears when entering the phone number.

Let us know if there is anything specific we can do to help diagnose the problem. Thanks!

@isupremedyou
Copy link

isupremedyou commented Apr 9, 2020

@morganchen12
https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_a_text_input_view?language=objc

Warning
If you use a custom input view for a security code input text field, iOS cannot display the necessary AutoFill UI.

The project will need to be updated to use a UITextField for the code entry. It should be possible to accomplish a similar visual appearance, but more importantly the UX of autofill will greatly increase the usefulness of the iOS PhoneAuth.

I've use the Android counterpart for PhoneAuth and the experience is great. I'm a Swift dev, but I can give this a go...but if anyone is more experienced with Objective-C and can get to it quicker, please do. We need to change FUICodeField to be a subclass of UITextField

Edit: I definitely misread that. It should work, however I went ahead and gave subclassing UITextField a shot to see if that helps. Can someone more experienced than I try and test my implementation? I'll link to the PR below

@morganchen12
Copy link
Contributor

Good catch @isupremedyou, thanks for submitting a fix. I'll take a look at it today.

@lydulApps
Copy link

So, is this fixed?

@gonencmete
Copy link

I'm still having this issue. Both phone number and OTP autofills are not working.

@liambolling
Copy link

This is still not fixed, please reopen

@nikitaame
Copy link

A fix for this coming?

@JustinRohweller
Copy link

I believe it's possible the issue is because the code is always before the word code, and supposedly the requirements from Apple are to have the code come AFTER the word "code".
As in, the template has the code as the first thing the user sees, but Apple wants it after the word "code":
https://github.com/facebook/react-native/issues/22578#issuecomment-510403610

@jainsoumya647
Copy link

Hey @morganchen12, This is really an important feature in the perspective of the UX and this is the basic need of the user. I request you to please resolve this issue ASAP. We are having multiple requests for this feature because of the inertia facing by the user.

Looking for your faster response and resolution.

@yuchenshi
Copy link
Member

I've filed a bug (b/170673572) internally to track this.

@barGenda
Copy link

barGenda commented Dec 2, 2020

Something new with this feature request?

@willbattel
Copy link

Yeah, I hate to be a bother but, this is an annoyance that I expected to be solved by now. This issue is over a year old and, while I know the Firebase team has a lot on their plate, this has become a pain point we cannot ignore.

I have a lot of faith in the Firebasers, and we want to continue using FirebaseUI because it does simplify things for us as designed. At your earliest convenience, can we please get more attention towards resolving this issue?

@isupremedyou
Copy link

Anyone wanting this fixed should take a look at this PR and figure out what's missing. I don't have time to get back to this, but it looks like progress was made by others.

#852 (comment)

@morganchen12
Copy link
Contributor

This is fixed in the latest version of FirebaseUI. Thanks to @akivab and @isupremedyou for your contributions!

Please let me know if this bug regresses and I'll reopen the issue.

@nconfrey
Copy link

NOTE: If you are still having this issue, check your Podfile: I was following the official README instructions, which pegged the version to 8.0. Update your podfile (or use swift package manager pointing to the master branch of this repo), and you'll pull in the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.