Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email textfield is not enabled when allowNewEmailAccounts is set to NO #814

Closed
tikipatel opened this issue Dec 14, 2019 · 1 comment
Closed

Comments

@tikipatel
Copy link

Welcome to FirebaseUI and thanks for submitting an issue!

If not, please feel free to fill in the following info so we can help faster!

Step 1: Are you in the right place?

Yes.

Step 2: Describe your environment

  • Objective C or Swift: Swift
  • iOS version: iOS 13
  • Firebase SDK version: Unrelated
  • FirebaseUI version: 8.4.0
  • CocoaPods Version: N/A

Step 3: Describe the problem:

When using FUIEmailAuth where allowNewEmailAccounts is set to NO, the user is unable to tap the email textfield to enter an email.

Steps to reproduce:

  1. Instantiate an instance of FUIEmailAuth with allowNewEmailAccounts as NO
  2. Instantiate an instance of FUIAuth and add the above as a provider
  3. Run the app and tap Sign in with email

Observed Results:

  • Unable to enter email address.

Expected Results:

  • Should be able to enter email address.

Relevant Code:

https://github.com/firebase/FirebaseUI-iOS/blob/master/EmailAuth/FirebaseEmailAuthUI/FUIPasswordSignInViewController.m#L262

I think that cell.textField.enabled should only be NO when the _email property of the FUIPasswordSignInViewController class is non-null.

For a better experience, the email textfield should always be enabled in case the user wants to use a different email to sign in.

@tikipatel tikipatel changed the title Email textfield is not enabled when allowNewEmailAccounts Email textfield is not enabled when allowNewEmailAccounts is set to NO Dec 14, 2019
@morganchen12
Copy link
Contributor

The fix for this has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants