Merge pull request #771 from firebase/jw-signOut-promise

Updated signOut() to return a promise
FirebaseExtended · Jun 21, 2016 · 49452e3 · 49452e3
2 parents a736588 + 046e7f8
commit 49452e3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/FirebaseAuth.js b/src/FirebaseAuth.js
@@ -139,7 +139,9 @@
      */
     signOut: function() {
       if (this.getAuth() !== null) {
-        this._auth.signOut();
+        return this._q.when(this._auth.signOut());
+      } else {
+        return this._q.when();
       }
     },
 

diff --git a/tests/unit/FirebaseAuth.spec.js b/tests/unit/FirebaseAuth.spec.js
@@ -315,6 +315,10 @@ describe('FirebaseAuth',function(){
   });
 
   describe('$signOut()',function(){
+    it('should return a promise', function() {
+      expect(authService.$signOut()).toBeAPromise();
+    });
+
     it('will call signOut() on backing auth instance when user is signed in',function(){
       spyOn(authService._, 'getAuth').and.callFake(function () {
         return {provider: 'facebook'};