Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mockfirebase to devDeps #416

Closed
wants to merge 1 commit into from
Closed

Move mockfirebase to devDeps #416

wants to merge 1 commit into from

Conversation

cebor
Copy link
Contributor

@cebor cebor commented Aug 29, 2014

shouldn't be mockfirebase a devDep? bower installs this with angularFire and wiredep puts it to my index.html.

@coveralls
Copy link

Coverage Status

Coverage decreased (-76.44%) when pulling 2914354 on cebor:patch-1 into de8666a on firebase:master.

@katowulf
Copy link
Contributor

Seems appropriate, but it looks like your version change broke the build?

@coveralls
Copy link

Coverage Status

Coverage decreased (-76.44%) when pulling a2681dd on cebor:patch-1 into 0274132 on firebase:master.

also update it to 0.3.0
@coveralls
Copy link

Coverage Status

Coverage decreased (-76.44%) when pulling fa9c6dc on cebor:patch-1 into 0274132 on firebase:master.

@jwngr
Copy link

jwngr commented Sep 2, 2014

@katowulf - Note that this did not actually successfully pass in Travis. Not sure why it said it did...

@jwngr
Copy link

jwngr commented Sep 3, 2014

@cebor - It looks like the path to MockFirebase.js changed with the 0.3.0 release. As per the package.json, the new path should be src/MockFirebase.js, not dist/mockfirebase.js. So you will need to update the path here and here. Should only take a minute! Once that's done, Travis should pass and we can merge this change in. Thanks!

cc/ @bendrucker since he made the change to mockfirebase.

@bendrucker
Copy link
Contributor

The path did change, but it's to browser/mockfirebase.js in order to clarify usage. In Node or with Browserify you'd want the real modules via require('mockfirebase'). The browser build packages a hack for exposing multiple window globals since a standard UMD wrapper can't do that. Accordingly, the main file in bower.json is ./browser/mockfirebase.js since I assume anyone using Bower is either using AMD or no module loader.

I'll open a separate PR that updates things properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants