Cache index keys in $indexFor #460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oolean. $$notify now called by SyncObject.
src/FirebaseArray.js - _notify renamed to $$notify - _process renamed to $$process - $$process no longer called internally by $$added/$$updated/$$moved/$$removed - $$added now returns a record - $$updated now returns a boolean indicating whether anything changed - $$moved now returns a boolean indicating whether record should be moved - $$removed now returns a boolean indicating whether record should be removed src/firebase.js: SyncArray to support new $$process usage - $$process now called after $$added, $$updated, $$removed, and $$moved (instead of coupled to those methods) - $$updated, $$moved, and $$removed only called if rec exists in the array test/jasmineMatchers.js: added toHaveCallCount(), toBeEmpty(), and toHaveLength()
src/FirebaseArray.js: added a cache of record indices test/unit/firebase.spec.js: Fix broken test case test/mocks/mock.utils.js: unused parameter
|
unmunging... |
|
Changes Unknown when pulling 75a3f96 on kato-indexfor into * on master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jwngr important because we now call $indexFor 2-5 times for each add/update event.