Removed deprecated auth methods and functionality #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }; | ||
| // Throw an error if they are trying to pass in separate string arguments | ||
| if (typeof credentials === "string") { | ||
| throw new Error("Passing in credentials to $createUser() as individual arguments has been removed in favor of a single credentials argument. See the AngularFire API reference for details."); |
There was a problem hiding this comment.
This could be ambiguous, as the context assumes one is upgrading and has read the old API docs. Maybe we should just say "$createUser() expects an object containing email and password arguments, but received a string."? Same suggestion for below.
There was a problem hiding this comment.
I realize this wasn't your change, but I think we're far enough out from the upgrade point to go ahead and be more general.
|
One minor suggestion. Feel free to ignore. |
|
@katowulf - Good call on the error messages. I took your suggestion. Back to you! |
katowulf
added a commit
that referenced
this pull request
Feb 15, 2015
Removed deprecated auth methods and functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@katowulf - Since we are going to do a major version bump, we can get rid of some old cruft. This removes all deprecated methods and functionality in our auth stuff. Here is a list of changes:
$firebaseAuthas individual arguments has been removed in favor of a single credentials argument. We now throw a helpful error message.$sendPasswordResetEmail()method has been removed; use the equivalent$resetPassword()method instead.