Adds API reference #754
Adds API reference #754
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
Looks good to me Abe! Back to you for merging. Please use a squash commit :) |
| @@ -93,7 +93,7 @@ $ grunt install # install Selenium server for end-to-end tests | |||
| $ export ANGULARFIRE_TEST_DB_URL="https://<YOUR-DATABASE-NAME>.firebaseio.com" | |||
| ``` | |||
|
|
|||
| 3. Update the entire `config` variable in [`tests/initialize.js`](../tests/initialize.js) to | |||
| 3. Update the entire `config` variable in [`tests/initialize.js`](/tests/initialize.js) to | |||
There was a problem hiding this comment.
This link can't be right? Should be tests/initialize.js in both places?
|
@AbeHaskins this almost lgtm! There are two items I'm concerned about:
|
|
Fixed staging URLs - great catch The |
| @@ -66,7 +66,7 @@ $ bower install angularfire --save | |||
|
|
|||
| * [Quickstart](docs/quickstart.md) | |||
| * [Guide](docs/guide/README.md) | |||
| * [API Reference](https://angularfire.firebaseapp.com/api.html) | |||
| * [API Reference](docs/reference.md) | |||
There was a problem hiding this comment.
The /s work fine though, check out this file and try the reference link :)
In that case, is this one incorrect? Shouldn't it also begin with a /? Sigh, I feel like a GitHub noob suddenly. I didn't know I was so poorly versed in how URLs work.
There was a problem hiding this comment.
No, this page is at the root of the repo, so you don't need the leading /. It's just like doing require() in Node. Relative paths are relative to the current file and absolute paths are relative to the root of the repo.
|
One last comment, Abe! Then we're ready to merge. |
|
Looks good Abe! |
Moves the Angularfire API reference into this repository